Another SVN branch?

Another SVN branch?, a forum discussion on Jojo CMS. Join us for more discussions on Another SVN branch? on our Suggestions & Feedback forum.

Back to Forum Index : Back to Suggestions & Feedback   RSS
Rick Rick

27 May 2010
Posts: 336

Would anybody else have use for another branch of the core?

At present the trunk is quite unstable and only PHP 5.3, and I've got one or two things that could probably use a second set of eyes before hitting the 1.0 branch.

Anyhoo, I'll attach the code. Basically if fixes the bug where wrong page would get chosen when there's multiple pages (specifically sub pages) using the same page link.

Attached Files

Jaijaz Jaijaz

31 May 2010
Posts: 215

Ordinarily I would think that a 1.1 branch might be in order? Except with 1.0 not officially released, it may work with that?

Anyway, Rick, I've downloaded a copy of your attachment and will test it when I can.
If you not living on the edge you taking up too much space.
Jaijaz Jaijaz

31 May 2010
Posts: 215

Ordinarily I would think that a 1.1 branch might be in order? Except with 1.0 not officially released, it may work with that?

Anyway, Rick, I've downloaded a copy of your attachment and will test it when I can.
If you not living on the edge you taking up too much space.
Rick Rick

31 May 2010
Posts: 336

Thanks. It should fix problems that come up with the wrong page being selected (influences for pageid, selectedpages, etc) where you have multiple sub pages using the same pg_link. Eg blog/coding, blog/rants, blog/gaming once you go one more level, eg blog/coding/some-blog-post. The right page isn't always selected, probably blog/rants.

I'm actually keen to use a similar method to what I've put in the patch to make it easier for the plugins to have sub pages. So without registering URIs, a plugin would still get called for all sub pages (if the actual page didn't exist) to it's pages. It can then check and if the content doesn't exist, then pump out a 404 (ideally through a single-line function to keep things simple and easy to change).

This could mean we don't have to register URIs as much, and make things easier than having functions such as isArticleURL() etc.

We'd still need to register URIs for things such as Google verification and the maps kml file (stuff without a specific url)

Just a thought.
Rick Rick

31 May 2010
Posts: 336

In regards to a branch... would a 0.9 branch be appropriate? Or shift the current trunk into a 2.0 branch?

If everyone else is fine with the current branches then that's cool, I've found myself being a lot more reserved with the 1.0 branch with stuff that I want to put in but might need more testing before hitting 1.0
tom

Developer

tom

2 Jun 2010
Posts: 379

I think Mike C is looking to commit a release from branch as a 1.0 tag as it seems pretty stable - at which point branch itself can probably afford to be a bit more experimental.

I'll have a play with your code also, as it may be useful for the trunk re-jig i'm looking at to get rid of categories
mikec

Lead Developer

mikec

18 Jun 2010
Posts: 67

Hi guys, if you hadn't already noticed. Jojo 1.0.0 stable has been tagged.

Feel free to be a bit more adventurous on the Jojo 1.0 branch. As much as possible keep your changes backwards compatible or at least an easy upgrade.

- Mike
Back to Forum Index : Back to Suggestions & Feedback   RSS
You must be logged in to post a reply



You need to Register or Log In before posting on these forums.